Docker Library - manifest cleanup #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, not mandatory but following is cleaner: podman images --format=json |
jq --arg lastweek "$lastweek" '.[] | select(.Created <= ( $lastweek | tonumber ) and .Dangling? ) | .Id' |
xargs --no-run-if-empty podman rmi --force ||
echo "continuing cleanup anyway |
jq --arg x v implies x is always a string. This doesn't work when its compared to a number as as such all images are cleared. Make removal around Dangling match the comment. Ensure that buildah images removed have a mariadb name (otherwise it picks up ubuntu/mysql images in repo). Simplify other select expressions to include more. Yes, buildah and podman put different capitalization on .Id/.id files in json format
grooverdan
force-pushed
the
mariadb_cleanup
branch
from
04864c7
to
03ce360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jq --arg x v implies x is always a string. This
doesn't work when its compared to a number as as such all images are cleared.
Make removal around Dangling match the comment.
Ensure that buildah images removed have a mariadb name (otherwise it picks up ubuntu/mysql images in repo).
Simplify other select expressions to include more.
Yes, buildah and podman put different capitalization on .Id/.id files in json format
Template selection
Please go the the
Previewtab and select the appropriate sub-template: