Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow !buy booster to just work #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow !buy booster to just work #118

wants to merge 2 commits into from

Conversation

spenceshady
Copy link
Contributor

To partially address #62

Marenthyu
Marenthyu reviewed Mar 16, 2021
View reviewed changes
Copy link
Owner

@Marenthyu Marenthyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure (am on mobile) about the logic flow at this point - but since we're re-writing the command, we should return after manually invoking do_command to avoid duplicate processing.

@spenceshady
Copy link
Contributor Author

Indeed, had missed the return statement. Committed a fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marenthyu Marenthyu Marenthyu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spenceshady @Marenthyu