Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement FFZ Websocket stuff with websocket-client #22

Open
Marenthyu opened this issue Nov 30, 2017 · 2 comments
Open

Reimplement FFZ Websocket stuff with websocket-client #22

Marenthyu opened this issue Nov 30, 2017 · 2 comments

Comments

@Marenthyu
Copy link
Owner

This turns out to be a tiny bit tricky, due to how FFZ and websocket-client handle the Origin Header - FFZ expects the Handshake's Origin header to be a) not set, b) be an empty String or c) be .twitch.tv

This can be worked around for now by setting the origin header to something.twitch.tv until you can omit the header or set it to an empty string with websocket-client ( see websocket-client/websocket-client#368 )
@Marenthyu
Copy link
Owner Author

A little context on why this is done in FFZ: https://twitter.com/SirStendec/status/936278949541351425?s=17

@Marenthyu
Copy link
Owner Author

websocket-client/websocket-client#368 has been fixed and merged, but a typo prevents it from working. Local install has been made with https://github.com/Marenthyu/websocket-client/tree/patch-1 which works for now, but we should switch to the pyPi version once the issue gets resolved and it pushed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Marenthyu