Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to download the image/video #37

Open
MarcusOtter opened this issue Nov 28, 2019 · 1 comment
Open

Add method to download the image/video #37

MarcusOtter opened this issue Nov 28, 2019 · 1 comment
Assignees
@MarcusOtter
Labels
enhancement New feature or request
Milestone
2.0

Comments

@MarcusOtter
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently the library only gives the users an URL and tell them if it's an image or a video and leave the downloading up to the user.

Describe the feature you'd like
It would be nice to provide a DownloadMedia method on the ApodClient that downloads the content and returns it (maybe as byte[]? I'm not sure what format would be preferred for users).
@MarcusOtter MarcusOtter added the enhancement New feature or request label Nov 28, 2019
@MarcusOtter MarcusOtter added this to the Nice-to-haves milestone Nov 28, 2019
@MarcusOtter MarcusOtter self-assigned this Nov 28, 2019
@MarcusOtter
Copy link
Owner Author

Known video sources:
youtube.com (example: 2019-02-05)
vimeo.com (example: 2019-01-20)
ustream.tv (example: 2019-06-02)

Youtube is most common by far.
Videos would probably not be downloadable

@MarcusOtter MarcusOtter modified the milestones: Future, 2.0 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusOtter MarcusOtter

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@MarcusOtter