Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement batch API calls #12

Open
MarcusOtter opened this issue Nov 11, 2019 · 1 comment
Open

Implement batch API calls #12

MarcusOtter opened this issue Nov 11, 2019 · 1 comment
Assignees
@MarcusOtter
Labels
enhancement New feature or request
Milestone
Future

Comments

@MarcusOtter
Copy link
Owner

MarcusOtter commented Nov 11, 2019 •
edited
Loading

To prevent timeouts, the library could provide an option to split requests that take a very long time into multiple requests and then return those results asynchronously using the new async iterators in C# 8.

The method should force the user to specify results per request within a reasonable range (1-50?) to give them some control over how many of their api requests they're using.
@MarcusOtter MarcusOtter added the enhancement New feature or request label Nov 11, 2019
@MarcusOtter MarcusOtter added this to the Nice-to-haves milestone Nov 11, 2019
@MarcusOtter MarcusOtter self-assigned this Nov 11, 2019
@MarcusOtter
Copy link
Owner Author

Since the library targets .NET Standard 2.0 we can't use C# 8. This could still be a feature to fetch the data in batches, which has the drawback of taking longer time and more API requests but users will not encounter timeouts.

@MarcusOtter MarcusOtter changed the title Implement async iterators Implement batch API calls Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusOtter MarcusOtter

Labels
enhancement New feature or request
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@MarcusOtter