Allow mapml-viewer / map[is=web-map] to work inside a shadow host / custom element #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popupTabNavigation.test.js. Playwright docs say page.click('body') is
discouraged...
layerContextMenuKeyboard and popupTabNavigation, hopefully
…Web-Map-Custom-Element into vector-tile-overflow
getClosest(node,selector) - change mapml-viewer, web-map to add event listeners to parent host if element is in a shadow root
getClosest(node,selector) - change mapml-viewer, web-map to add event listeners to parent host if element is in a shadow root
Conflicts: test/e2e/core/popupTabNavigation.test.js test/e2e/elements/mapml-viewer/in-shadow-root.test.js
selector, and which traverses shadow roots. Remove duplicate getClosest implementations across various custom elements, standardize on use of M.getClosest Use M.getClosest to select ancestor map element and ancestor fullscreen element.
shadow host if being used inside a custom element. Add tests for getMapEl(), getLayerEl() across map-extent,map-feature, map-link, and map-input Add test for fullscreen map[is=web-map] in shadow host / custom element
…ement into in-shadow-root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.