Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cell_ids are not saved to sdata file #42

Open
sophiamaedler opened this issue Jul 24, 2024 · 1 comment
Open

cell_ids are not saved to sdata file #42

sophiamaedler opened this issue Jul 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sophiamaedler
Copy link
Collaborator

using write_element cell_ids that are saved to a labels element are not written to file and can not be reloaded

sophiamaedler added a commit that referenced this issue Jul 24, 2024
…attributes when loading from file

- currently the "cell_ids" that are added to attrs are not saved to file when using write_element as such they also can not be loaded
- this problem needs to be fixed long term till then this code ensures that they are recalculated upon loading so that the rest of the code can be adapted to work with the new sdata format until this fix is implemented

see #42
@sophiamaedler
Copy link
Collaborator Author

currently we have implemented a dirty fix which recalculates the cell_ids in each label layer upon reloading. This needs a more permanent solution potentially on the end of spatial data.

@sophiamaedler sophiamaedler added the bug Something isn't working label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant