Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete gem files in our build process #207

Open
kbrock opened this issue Sep 29, 2021 · 9 comments
Open

Don't delete gem files in our build process #207

kbrock opened this issue Sep 29, 2021 · 9 comments
Assignees

Comments

@kbrock
Copy link
Member

kbrock commented Sep 29, 2021

Background

Our process (loosely)

  • fetches files (git / bundler)
  • Deletes some files that are not necessary <=== focusing here
  • tars those files together
  • builds an rpm

Request

Drop the delete process and have the tar process exclude those files.

Desired result

This will consolidate the logic for the excluded files.

This also gets us closer to being able to reuse docker containers that build rpms, at least for local development.

Currently we have to throw away a docker container even when we make minor changes to our source code costing us over half an hour per change. Or more accurately, making us hack environments instead of testing them in environments similar to our customers.

If we can speed up the building of rpms, then a final test of a patch could be done with pods that are build with our real production process.

Compiling delay

@Fryguy
Copy link
Member

Fryguy commented Sep 30, 2021

I was thinking about this change as well. I noticed we do both tar exclusion and we have that method for cleansing the gemset. Doesn't make sense when, I think, the tar exclusion can handle both.

Currently we have to throw away a docker container even when we make minor changes to our source code costing us over half an hour per change. Or more accurately, making us hack environments instead of testing them in environments similar to our customers.

I don't understand how this is related. The gem install / tar build doesn't happen in a docker layer, so there's nothing to cache.

If you want to have a docker container that caches the built rpms layer, you can literally do that now by just introducing a new layer in the rpm build Dockerfile that does the actual RPM build.

@Fryguy
Copy link
Member

Fryguy commented Sep 30, 2021

@kbrock Unless I'm mistaken, this issue should be in the manageiq-rpm_build repo, right?

@kbrock
Copy link
Member Author

kbrock commented Oct 5, 2021

@kbrock Unless I'm mistaken, this issue should be in the manageiq-rpm_build repo, right?

sigh. correct

@Fryguy Fryguy transferred this issue from ManageIQ/manageiq-appliance Oct 5, 2021
@kbrock kbrock changed the title Don't delete files in our gem files in our build process Don't delete gem files in our build process Nov 7, 2021
@miq-bot miq-bot added the stale label Feb 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented May 29, 2023

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this as completed May 29, 2023
@kbrock kbrock removed the stale label Jul 13, 2023
@kbrock kbrock reopened this Jul 13, 2023
@miq-bot miq-bot added the stale label Oct 16, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Jan 22, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants