Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatter(nan_color...) works for CairoMakie but not GLMakie #3067

Closed
bjarthur opened this issue Jul 14, 2023 · 8 comments
Closed

scatter(nan_color...) works for CairoMakie but not GLMakie #3067

bjarthur opened this issue Jul 14, 2023 · 8 comments
Labels

Comments

@bjarthur
Copy link
Contributor

the point at x=y=6 should be red in both plots below, but is not in the first one, which uses GLMakie:

julia> using GLMakie

julia> fig, ax, li = scatter(1:10, 1:10, color=[1:5; NaN; 7:10], nan_color=colorant"red")
Screenshot 2023-07-14 at 4 37 50 PM

same exact code but with CairoMakie instead of GLMakie:

julia> using CairoMakie

julia> fig, ax, li = scatter(1:10, 1:10, color=[1:5; NaN; 7:10], nan_color=colorant"red")
Screenshot 2023-07-14 at 4 38 49 PM
(jl_lalGOb) pkg> st
Status `/private/var/folders/s5/8d629n5d7nsf37f60_91wzr40000gq/T/jl_lalGOb/Project.toml`
  [13f3f980] CairoMakie v0.10.6
  [e9467ef8] GLMakie v0.8.6

julia> VERSION
v"1.9.2"

julia> Sys.MACHINE
"arm64-apple-darwin22.4.0"
@bjarthur bjarthur added the bug label Jul 14, 2023
@bjarthur
Copy link
Contributor Author

not shown above is that WGLMakie works fine.

@lazarusA
Copy link
Contributor

I can reproduce this bug, :(.

@SimonDanisch
Copy link
Member

Ah jeez, this must be a gpu specific issue ... nans are super Ill defined on the gpu, and we tried hard to implement them in a way to work around most driver issues, but seems like there are still problems

@SimonDanisch
Copy link
Member

which gpu is this?

@SimonDanisch
Copy link
Member

Ah m2 I suppose -.-

@bjarthur
Copy link
Contributor Author

yes, M2. sorry for not specifying that earlier. didn't think it would make a difference.

thanks for looking into this! let me know if i can help fix it.

@SimonDanisch
Copy link
Member

Oh... I just noticed, that this wasn't actually implemented in GLMakie, even though everything was in place for it :-O
Should be fixed in #2900, which should get merged soon!

@SimonDanisch
Copy link
Member

Fixed in #2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants