Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery cards are missing #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazarusA
Copy link

@lazarusA lazarusA commented Sep 6, 2024

@jkrumbiegel this is the branch. Only the gallery cards were not working. All other things should be fine.

@jkrumbiegel
Copy link
Member

jkrumbiegel commented Sep 6, 2024

Hehe that's a big "only", that democards package is probably more work than I'd be willing to do to convert to vitepress because it writes its own html, with its own theming css etc. It seems to me that we'd need to convert those scripts to normal pages with @example blocks and then do something similar to Makie to make a page with preview images.

@lazarusA
Copy link
Author

lazarusA commented Sep 6, 2024

at some point I did try the new OhMyCards package, with some partial success, but at the time it was really hard for me to incorporate into this current workflow (and specially have author badge show at the top). Probably, things are better now, don't know, will need to check again.

@lazarusA
Copy link
Author

lazarusA commented Sep 6, 2024

@asinghvi17 is using it with some success here: https://geo.makie.org/v0.7.4/examples . Maybe later, I could take a look again.

@jkrumbiegel
Copy link
Member

Yeah just looked at that as well, looks promising. Let me know if you figure something out, I'll leave this until then :)

@asinghvi17
Copy link
Member

I have some time today so will take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants