Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python text Io deprecation #173

Open
ThomasCeulemans opened this issue Mar 2, 2023 · 0 comments
Open

Python text Io deprecation #173

ThomasCeulemans opened this issue Mar 2, 2023 · 0 comments
Assignees
@FredDeCeuster @ThomasCeulemans

Comments

@ThomasCeulemans
Copy link
Collaborator

In a long forgotten past, Magritte saved and stored models using text files. The old implementation has not been updated properly. Therefore, if we for some reason force Magritte to use the text io module (by default, we use the hdf5 implementation), it fails to read and write everything.

We have two options: either we deprecated the non-used text api or we rewrite the internal text api to work again.
I propose to deprecate the text api, as it is not advertised anywhere, and the hdf5 file format is better for storing the data either way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FredDeCeuster FredDeCeuster

@ThomasCeulemans ThomasCeulemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FredDeCeuster @ThomasCeulemans