Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for BRANCH coverage #67

Open
gokhan-oner opened this issue Aug 24, 2023 · 4 comments
Open

add support for BRANCH coverage #67

gokhan-oner opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
feature request New feature or request
Milestone

Comments

@gokhan-oner
Copy link

gokhan-oner commented Aug 24, 2023

It'd be usefull to add support for branch coverage as well.

PS: @thsaravana If idea is OK, I'm willing to do the necessary changes.

@gokhan-oner
Copy link
Author

@thsaravana @instrap I'm creating a PR for this, but tests are using some predefined values in the jacoco-playground repo it seems. How should I progress? Do you have a guide?

@thsaravana thsaravana self-assigned this Oct 18, 2023
@thsaravana
Copy link
Member

Thanks. Could you run the approach you are taking before working on it? We have plans to make this configurable, so that the user can choose the type of coverage (this could be multiple types as well).

As for the unit tests, the unit tests reflects the jacoco-playground, since it's easy to test and also update the report.xml mock. Feel free to create new report.xml for 'branches' and you can write your test against that.

@alpeshvas
Copy link

@gokhan-oner @thsaravana any update here?

@instrap instrap added this to the 1.7.3 milestone Sep 8, 2024
@instrap
Copy link
Member

instrap commented Sep 8, 2024

I am adding this to 1.7.3 for now. We will pick this up after #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants