Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hilt integration #28

Open
jakoss opened this issue Aug 12, 2020 · 2 comments
Open

Hilt integration #28

jakoss opened this issue Aug 12, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jakoss
Copy link

jakoss commented Aug 12, 2020

Great plugin you got there! I have one issue - in new project, based directly on Hilt, the Dagger window is empty:
image

I don't see any errors, projects build and runs just fine.

Tried on Android Studio 4.0.1 with Hilt 2.28.3-alpha

@thsaravana thsaravana self-assigned this Aug 20, 2020
@thsaravana thsaravana added the enhancement New feature or request label Aug 20, 2020
@thsaravana
Copy link
Member

The plugin works based on the Dagger-Spi plugin. If Hilt is not supported, then I believe Hilt is doing something else, probably byte code manipulation. Our original goal was not for Android projects, but rather non-android projects that uses Dagger.
Also, seems Android Studio now has support for Dagger (navigation). Is Hilt supported as part of that?

So to support Hilt, I believe we need to change the underlying implementation, may be just for projects that uses Hilt. I will try using Hilt and see what the generated code looks like, and why Dagger Spi is not fetching the graph 🤔

@jakoss
Copy link
Author

jakoss commented Aug 20, 2020

Dagger will be supported in Android Studio 4.1 (in RC now) and Hilt will be supported in Android Studio 4.2 (Canary). But as i understand - this support will be for navigation only. Your plugin is better for a top-down overview of the whole graph

@thsaravana thsaravana added the help wanted Extra attention is needed label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants