Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go! += disconnect! in case of earlier active connection #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

go! += disconnect! in case of earlier active connection #4

wants to merge 1 commit into from

Conversation

xkr47
Copy link
Contributor

@xkr47 xkr47 commented May 14, 2019

No description provided.

Macroz
Macroz requested changes May 14, 2019
View reviewed changes
Copy link
Owner

@Macroz Macroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm shouldn't we disconnect in current thread so there is no chance of race condition with next connect?

@xkr47
Copy link
Contributor Author

xkr47 commented May 14, 2019

True.. how do I ignore exceptions from disconnect! or figure out if we need to disconnect in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macroz Macroz Macroz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkr47 @Macroz