Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FUNC] Add an option for truncation from left #193

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

wonjininfo
Copy link
Member

Minor feature update, as discussed in the Friday meeting.

When the option --truncation_side_left is selected:

  • For an input sequence shorter than max_len, this option will not affect it. Padding will still be attached at the end of the example.
  • For an input sequence longer than max_len, the beginning part of the sequence will be deleted to fit within the max_len restriction.

@tmills
Copy link
Contributor

tmills commented Jan 19, 2024

@wonjininfo if you can double check my change to make sure it keeps the intended behavior then i'll merge the branch

@wonjininfo
Copy link
Member Author

Looks good to me!

@tmills tmills merged commit 331802b into dev-v0.7.0 Jan 24, 2024
3 checks passed
@tmills tmills deleted the truncate_left branch January 24, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants