Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmm....some naming issues in current version #9

Open
rednaxus opened this issue Jan 22, 2018 · 2 comments
Open

hmm....some naming issues in current version #9

rednaxus opened this issue Jan 22, 2018 · 2 comments

Comments

@rednaxus
Copy link

Hey, nice piece of work... but I just pulled this and it wouldn't compile until I fixed it because some names of directories and files are out of whack

    src/app/components/label/label.js
        src/app/components/tabPanel/TabPanel/TabPanel.js
    src/app/components/tabPanel/TabPanelBodyContent/tabPanelBodyContent.js
    src/app/views/simpleTables/simpleTables.js

should be:

src/app/components/label/Label.js
src/app/components/tabPanel/tabPanel/
src/app/components/tabPanel/tabPanelBodyContent/
src/app/views/simpleTables/SimpleTables.js
@A1Darkwing
Copy link

Nice Rednaxus. I fixed this issue before I read it

@kefahi
Copy link

kefahi commented Apr 20, 2018

Thank you @rednaxus for the tip, you saved my day. I guess the issue mainly manifests on Linux and not on MacOS (as filenames on MacOS are not case-sensitive).

Here is what I had to run in a single shot to fix it. (based on Rendaxus's note)

cd ./src/app/
mv ./components/label/label.js ./components/label/Label.js
mv ./views/simpleTables/simpleTables.js ./views/simpleTables/SimpleTables.js
mv ./components/tabPanel/TabPanelBodyContent  ./components/tabPanel/tabPanelBodyContent
mv ./components/tabPanel/TabPanel ./components/tabPanel/tabPanel
mv ./components/tabPanel/tabPanelBodyContent/tabPanelBodyContent.js  ./components/tabPanel/tabPanelBodyContent/TabPanelBodyContent.js

Ideally this should be fixed in the repo as well, so others wont encounter the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants