Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for fee.h #10

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Fixes for fee.h #10

merged 3 commits into from
Jun 19, 2024

Conversation

robotopia
Copy link
Contributor

  • Removed redundant for loop over directions
  • Added explicit safeguard against threads >= num_directions
  • Moved Legendre and P1* arrays to global memory
    • Added explicit direction dependence to arrays

@robotopia
Fixes for fee.h
99a5080 
- Removed redundant for loop over directions
- Added explicit safeguard against threads >= num_directions
- Moved Legendre and P1* arrays to global memory
  - Added explicit direction dependence to arrays
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (4269142) to head (e8414f3).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files          16       16           
  Lines        3305     3305           
=======================================
  Hits         2810     2810           
  Misses        495      495

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d3v-null d3v-null merged commit 87f0d34 into MWATelescope:main Jun 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3v-null d3v-null d3v-null left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robotopia @d3v-null