-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a step for remapping topography from MALI #829
base: main
Are you sure you want to change the base?
Conversation
0b54306
to
959da20
Compare
Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
be2486f
to
b5e6880
Compare
Updated Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions. |
e512590
to
824f8f5
Compare
During the `cull_mesh` step of creating a global ocean mesh, if ice-shelf cavities are present, we need to flood fill to make sure all land ice is connected (no islands of isolated land ice). This merge changes the flood fill to be on all locations where `landIceFraction > 0`, not all locations where `landIceFraction > 0.5`. It then masks all `landIce*` fields to only be nonzero within the flood-filled region. This prevents islands of nonzero `landIceFraction`, `landIcePressure`, `landIceDraft`, etc.
Switch SO12to60 to SO12to30 with a base resolution that is now uniformly 30 km.
When we plot histograms of the initial condition, now plot histograms of the water-column thickness in the open ocean and in cavities.
In cavities, we thicken the water column to make sure it has the minimum thickness. The hope is that this makes the vertical coorinate converge more quickly and smoothly to its final result.
MALI topogrpahy gets combined with BedMachine Antarctica/GEBCO. For now, the masks for the grounding line, calving front, etc. are form BedMachine, not MALI, so that the same horizontal mesh and mapping files can be used with BedMachine and MALI topogrpahy.
These will change the locaiton of the grounding line and calving front, so that the resulting ocean grid will be different from the equivalent from BedMachine.
Move ocean_density and sea_level to config options
MALI topography as well as masks for land ice, floating ice and ocean get combined with BedMachine Antarctica/GEBCO.
Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changesTesting
in this PR) any testing that was used to verify the changes