Add suite of flux-corrected transport tests for landice integration #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trhille
added
enhancement
| landice/dome/variable_resolution/fo_fct_restart_test | ||
| landice/greenland/fo_fct_decomposition_test | ||
| landice/greenland/fo_fct_restart_test | ||
| landice/thwaites/fct_decomposition_test |
There was a problem hiding this comment.
I'm wondering if we ought to revamp the naming conventions to make it clear when 'fo' or other abbreviations refer to velocity solve vs advection vs other possible settings. I imagine compass list is getting pretty busy.
There was a problem hiding this comment.
Also, making a note that we'll need to change the names of the tests in the full_integration suite (and docs) accordingly (discovered this trying to run full_integration from this branch).
Add new fct advection tests for dome group
The namelist files in the run step were not being properly updated to ust fct advection. This fixes that.
Add 3km fct full physics tests for humboldt. Note that the decomposition tests do not pass validation, but testing shows that they also fail using fo advection.
Add fct_integration suite, which uses a subset of the new fct advection tests based on the tests in full_integration.
Fix names of thwaites tests in suite definition file. Note that the
naming convention of these tests is currently {advection}_{velocity_solver},
which is the reverse of the convention for other tests. This will be
addressed in a future commit.
trhille
force-pushed
the
landice/add_fct_advection_suite
branch
from
d5f5b64
to
c884eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suite of landice integration tests using flux-corrected transport that is currently being implemented in MALI-Dev/E3SM#70.
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes