Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant concentration condition (ICBUND < 0) is not persistent #82

Open
DarkForceOne opened this issue Aug 24, 2020 · 4 comments
Open

Comments

@DarkForceOne
Copy link

The block between line 327 and 338 of the ssm1.f should be removed.

@emorway-usgs
Copy link
Collaborator

@DarkForceOne If you have a small example problem demonstrating the problem, that would be helpful as we recall why this code was added? I can see that the block of code you are referring to (shown below) undoes a constant concentration condition specified in BTN when NTMP is specified as something great than 1 in SSM (otherwise, this code won't be triggered).

C-------RESET ICBUND TO ABS(ICBUND) FOR CONSTANT CONCENTRATION CELLS
        DO INDEX=1,NCOMP
          DO KK=1,NLAY
            DO II=1,NROW
              DO JJ=1,NCOL
                IF(ICBUND(JJ,II,KK,INDEX).LT.0) THEN
                  ICBUND(JJ,II,KK,INDEX)=ABS(ICBUND(JJ,II,KK,INDEX))
                ENDIF
              ENDDO
            ENDDO
          ENDDO
        ENDDO  

@vivekbedekar Do you recall why this code was added? It looks like if first showed up with a commit you made in 2015:
constantc

@DarkForceOne
Copy link
Author

DarkForceOne commented Aug 25, 2020 via email

@vivekbedekar
Copy link
Collaborator

vivekbedekar commented Aug 25, 2020 via email

@emorway-usgs
Copy link
Collaborator

@DarkForceOne Hi Eric, I think a work around for your case could be to set ICBUND=1 for the constant concentration cells and then in SSM input, you could set the ITYPE for your constant concentration cells equal to -1. Using this approach, the constant concentration condition will persist in multiple stress period simulations. If this solution works for you, would you mind closing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants