Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++14 required? #1

Open
ToniRV opened this issue Nov 25, 2019 · 1 comment
Open

C++14 required? #1

ToniRV opened this issue Nov 25, 2019 · 1 comment
Assignees

Comments

@ToniRV
Copy link
Contributor

ToniRV commented Nov 25, 2019

Reporting the issue MIT-SPARK/Kimera-VIO-ROS#17 here, which seems to be the offending package.
I'll have a quick look myself and update this PR, but if you could give it a try at some point @yunzc that would be great! Thanks!

@ToniRV
Copy link
Contributor Author

ToniRV commented Nov 26, 2019

Ok, no clue why 😅
Nevertheless @yunzc can you take care of the following as well:

  • Add License Missing license file #2
  • Add clang formate file
  • Format the whole repo (it is quite inconsistent right now, and there are tabs and spaces everywhere 😢)
  • Use pragma once in header files
  • Call ros::spin(); in the main rather than in the ctor of visualizer
  • Don't use long unsigned int unnecessarily. Best is if you typedef that with some conceptually meaningful name and then change to your convenience, perhaps a uint would be enough.
  • Don't use auto unless really necessary, otw it will bring you more problems than solutions (and I think it might be the root cause of this issue).
  • Can you also add a Readme: what is this repo doing and perhaps how to use it 👍

ToniRV added a commit that referenced this issue Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants