From cad461c1955714e93f78ba2e27efb5e8300c5a98 Mon Sep 17 00:00:00 2001
From: Michael Scanlan <mscanlan15@gmail.com>
Date: Wed, 13 Sep 2023 15:53:42 -0400
Subject: [PATCH] Cleaned up variable names to be consistent. Changed submenu
 names. Changed url link name.

---
 .../templates/console/console_navbar.html     | 10 ++++----
 .../console/{event.html => event_active.html} |  4 +--
 ..._archive_event.html => event_archive.html} |  4 +--
 physionet-django/console/urls.py              |  8 +++---
 physionet-django/console/views.py             | 25 +++++++++----------
 5 files changed, 25 insertions(+), 26 deletions(-)
 rename physionet-django/console/templates/console/{event.html => event_active.html} (92%)
 rename physionet-django/console/templates/console/{event_archive_event.html => event_archive.html} (95%)

diff --git a/physionet-django/console/templates/console/console_navbar.html b/physionet-django/console/templates/console/console_navbar.html
index de4bdb782d..3ffd116272 100644
--- a/physionet-django/console/templates/console/console_navbar.html
+++ b/physionet-django/console/templates/console/console_navbar.html
@@ -123,16 +123,16 @@
               <span class="nav-link-text">Events</span>
             </a>
             <!-- submenu -->
-          {% if events_nav or archive_event_nav %}
+          {% if nav_event_active or nav_event_archive %}
             <ul class="sidenav-second-level collapse show" id="events">
           {% else  %}
             <ul class="sidenav-second-level collapse" id="events">
           {% endif %}
-              <li class="nav-item {% if events_nav %}active{% endif %}">
-                <a id="nav_events" class="nav-link" href="{% url 'event' %}">Event List</a>
+              <li class="nav-item {% if nav_event_active %}active{% endif %}">
+                <a id="nav_event_active" class="nav-link" href="{% url 'event_active' %}">Active</a>
               </li>
-              <li class="nav-item {% if archive_event_nav %}active{% endif %}">
-                <a id="nav_archive_event" class="nav-link" href="{% url 'archive_event' %}">Archived Events</a>
+              <li class="nav-item {% if nav_event_archive %}active{% endif %}">
+                <a id="nav_event_archive" class="nav-link" href="{% url 'event_archive' %}">Archived</a>
               </li>
             </ul>
         </li>
diff --git a/physionet-django/console/templates/console/event.html b/physionet-django/console/templates/console/event_active.html
similarity index 92%
rename from physionet-django/console/templates/console/event.html
rename to physionet-django/console/templates/console/event_active.html
index 2c07f7512f..9f7add0068 100644
--- a/physionet-django/console/templates/console/event.html
+++ b/physionet-django/console/templates/console/event_active.html
@@ -13,7 +13,7 @@
 {% block content %}
 <div class="card mb-3">
     <div class="card-header">
-        Events <span class="badge badge-pill badge-info">{{ events.paginator.count }}</span> 
+        Active Events <span class="badge badge-pill badge-info">{{ event_active.paginator.count }}</span> 
     </div>
     <div class="card-body">
         <div class="table-responsive">
@@ -32,7 +32,7 @@
                 </tr>
               </thead>
               <tbody>
-              {% for event in events %}
+              {% for event in event_active %}
                 <tr>
                     <td><a href="{% url 'event_detail' event.slug %}">{{ event.title }}</a></td>
                     <td>{{ event.get_category_display|title }}</td>
diff --git a/physionet-django/console/templates/console/event_archive_event.html b/physionet-django/console/templates/console/event_archive.html
similarity index 95%
rename from physionet-django/console/templates/console/event_archive_event.html
rename to physionet-django/console/templates/console/event_archive.html
index 7e37ab99ac..178dc045d0 100644
--- a/physionet-django/console/templates/console/event_archive_event.html
+++ b/physionet-django/console/templates/console/event_archive.html
@@ -13,7 +13,7 @@
 {% block content %}
 <div class="card mb-3">
     <div class="card-header">
-        Archived Events <span class="badge badge-pill badge-info">{{ archive_event.paginator.count }}</span> 
+        Archived Events <span class="badge badge-pill badge-info">{{ event_archive.paginator.count }}</span> 
     </div>
     <div class="card-body">
         <div class="table-responsive">
@@ -32,7 +32,7 @@
                 </tr>
               </thead>
               <tbody>
-              {% for event in archive_event %}
+              {% for event in event_archive %}
                 <tr>
                     <td><a href="{% url 'event_detail' event.slug %}">{{ event.title }}</a></td>
                     <td>{{ event.get_category_display|title }}</td>
diff --git a/physionet-django/console/urls.py b/physionet-django/console/urls.py
index be1da76e2a..9f8922aa97 100644
--- a/physionet-django/console/urls.py
+++ b/physionet-django/console/urls.py
@@ -146,10 +146,10 @@
     ),
     path('code-of-conducts/<int:pk>/activate/', views.code_of_conduct_activate, name='code_of_conduct_activate'),
     # Lists of event components
-    path('event/', views.event,
-         name='event'),
-    path('archive_event/', views.archive_event,
-         name='archive_event'),
+    path('event/active/', views.event_active,
+         name='event_active'),
+    path('event/archived/', views.event_archive,
+         name='event_archive'),
     path('event/manage/<event_slug>', views.event_management, name='event_management'),
     path('event_agreements/', views.event_agreement_list, name='event_agreement_list'),
     path('event_agreements/<int:pk>/', views.event_agreement_detail, name='event_agreement_detail'),
diff --git a/physionet-django/console/views.py b/physionet-django/console/views.py
index 8b801cc79b..769ba2b0b4 100644
--- a/physionet-django/console/views.py
+++ b/physionet-django/console/views.py
@@ -2938,31 +2938,30 @@ def code_of_conduct_activate(request, pk):
 
 
 @permission_required('user.view_all_events', raise_exception=True)
-def event(request):
+def event_active(request):
     """
     List of events
     """
-    events = Event.objects.all()
-    events = paginate(request, events, 50)
+    event_active = Event.objects.filter(end_date__gte=timezone.now())
+    event_active = paginate(request, event_active, 50)
 
-    return render(request, 'console/event.html',
-                  {'events': events,
-                   'events_nav': True
+    return render(request, 'console/event_active.html',
+                  {'event_active': event_active,
+                   'nav_event_active': True
                    })
 
 
 @permission_required('user.view_all_events', raise_exception=True)
-def archive_event(request):
+def event_archive(request):
     """
     List of archived events
     """
-    now = timezone.now()
-    archive_event = Event.objects.filter(end_date__lte=now)
-    archive_event = paginate(request, archive_event, 50)
+    event_archive = Event.objects.filter(end_date__lte=timezone.now())
+    event_archive = paginate(request, event_archive, 50)
 
-    return render(request, 'console/event_archive_event.html',
-                  {'archive_event': archive_event,
-                   'archive_event_nav': True
+    return render(request, 'console/event_archive.html',
+                  {'event_archive': event_archive,
+                   'nav_event_archive': True
                    })