Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAI endpoint error handling #432

Open
antmoth opened this issue Jun 28, 2019 · 4 comments
Open

OAI endpoint error handling #432

antmoth opened this issue Jun 28, 2019 · 4 comments
Assignees
Labels

Comments

@antmoth
Copy link
Collaborator

antmoth commented Jun 28, 2019

We should kindly inform the user that there is a problem if an attempted OAI harvest finds:
(1) a down endpoint
(2) no records

@antmoth antmoth self-assigned this Jun 28, 2019
@antmoth
Copy link
Collaborator Author

antmoth commented Jun 28, 2019

image
^ no records scenario maybe taken care of

handling "endpoint down or unreachable" might require a completely different code intervention. I knew there was a reason I thought those should be separate issues :D

@antmoth
Copy link
Collaborator Author

antmoth commented Jun 28, 2019

I'm not entirely sure that marking the job as invalid when it just has no records is the right thing to do... Maybe I should add a 'warning' state, 'errored' or something.

@antmoth
Copy link
Collaborator Author

antmoth commented Jul 2, 2019

The problem with 'down endpoint' is that when I try to, e.g., put in an invalid endpoint URL, the job seems to never stop trying, and to run forever? @ghukill

@antmoth antmoth added the bug label Jul 31, 2019
@antmoth
Copy link
Collaborator Author

antmoth commented Jul 31, 2019

Could run a health test on the endpoint/ping it before the Spark task runs. Error language needs to be friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant