Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdf_data not initialized properly when running solute.run() #101

Open
Caboomi opened this issue Apr 5, 2024 · 6 comments
Open

rdf_data not initialized properly when running solute.run() #101

Caboomi opened this issue Apr 5, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Caboomi
Copy link

Caboomi commented Apr 5, 2024

I am using ase to convert an xdatcar file to a xyz and pdb file and reading it into the mda.Universe as you can see in the pdf attached
vertopal.com_5x_analysis.pdf. I am receiving an error when running solute.plot_solvation_radius('Li', solvent) as KeyError: 'Li' despite having this:

solute = Solute.from_atoms(
dme_Li,
{'dme_TFSI': dme_TFSI, 'dme_DOL': dme_DOL, 'dme_DME': dme_DME},
solute_name="Li",
radii={"dme_TFSI": 2.6, "dme_DOL": 2.6, "dme_DME": 2.6}
)
as my solute.

I think it could stem from run() not initializing rdf_data properly as it creates solute_0 ... solute_4 in my rdf_data rather than having 'Li'in the directory. My Li solute is made up of 5 Li atoms.

@orionarcher
Copy link
Collaborator

I think it could stem from run() not initializing rdf_data properly as it creates solute_0 ... solute_4 in my rdf_data rather than having 'Li'in the directory. My Li solute is made up of 5 Li atoms.

Thanks for the report. I think you are probably right about this. Could you post the input files so I can take a look?

In the meantime, you could try using rename_solutes = {"solute_0": "Li", ..., "solute_4": "Li"} as a kwarg?

@orionarcher orionarcher added the bug Something isn't working label Apr 5, 2024
@Caboomi
Copy link
Author

Caboomi commented Apr 10, 2024

https://drive.google.com/drive/folders/1cdZyy6Cca2IfW2qwt9HVLevLtmYS_KH9?usp=sharing

You can find the files here. Thank you for the suggestion, it worked!

@Caboomi
Copy link
Author

Caboomi commented Apr 18, 2024

@orionarcher Were you able to fix it?

@orionarcher
Copy link
Collaborator

Not yet but I've observed the bug in another case and it's on my TODO list.

@orionarcher
Copy link
Collaborator

Hi Caboomi. I am taking a look at this but would appreciate some help.

Would you mind sending along a minimal reproduction of the bug? In particular, could 1) you remove the calls to ase and any other code not involved in direct generation of the bug 2) specify exactly which files I should be loading.

I don't have ase set up and I'd prefer to not have to configure a whole new environment to get to the bottom of this. Thank you!

@Caboomi
Copy link
Author

Caboomi commented Sep 18, 2024

Hey I am really sorry! I just saw this! I tried reproducing the bug but it's fixed now! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants