Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize docs and some fixes #48

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Reorganize docs and some fixes #48

merged 7 commits into from
Jan 30, 2024

Conversation

lilyminium
Copy link
Member

Fixes #33

Changes made in this Pull Request:

  • Adds docs back, fixes bibliography, organises to make a bit more sense, removes unused things, minor fixes to formatting, links, and otherwise.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Merging #48 (6171efe) into main (d24c397) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

docs/source/usage.rst Outdated Show resolved Hide resolved
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilyminium - overall lgtm, although I'm seeing these leftover versionadded (probably copied over from the core library). Should we remove them too?

@@ -30,280 +30,6 @@

.. versionadded:: 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this too? It looks like this is a holdover from the core library.

mdahole2/analysis/hole.py Outdated Show resolved Hide resolved
@lilyminium lilyminium merged commit c9e52b5 into main Jan 30, 2024
6 checks passed
@lilyminium lilyminium deleted the lilyminium/fix-33 branch January 30, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add back docs after switch to MDA theme
2 participants