Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the docs theme #23

Merged
merged 10 commits into from
Jul 16, 2023
Merged

Fixes to the docs theme #23

merged 10 commits into from
Jul 16, 2023

Conversation

ianmkenney
Copy link
Collaborator

  • Added msmb_theme dependency in workflow
  • Added sphinx_rtd_theme to requirements.yaml
  • Added new custom.css and MDA logos
  • Updated conf.py

Fixes #13

- Added msmb_theme dependency in workflow
- Added sphinx_rtd_theme to requirements.yaml
- Added new custom.css and MDA logos
- Updated conf.py
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #23 (bbd27dc) into main (0623ef2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@ianmkenney ianmkenney requested a review from orbeckst July 14, 2023 16:38
@orbeckst
Copy link
Member

Can you link to a PR build on RTD so that I can check visually? We should be doing such a build for each PR but I cannot set it under checks.

@ianmkenney
Copy link
Collaborator Author

ianmkenney commented Jul 14, 2023

@orbeckst we're using github pages, I'm not quite sure how to show the outputs of those builds on PRs, I might have to revisit this later then

@orbeckst
Copy link
Member

orbeckst commented Jul 14, 2023 via email

@ianmkenney
Copy link
Collaborator Author

@orbeckst Alright, docs are building, see https://mdakithole2--23.org.readthedocs.build/en/23/

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & thanks for adding the RTD PR check.

@orbeckst orbeckst linked an issue Jul 16, 2023 that may be closed by this pull request
@ianmkenney ianmkenney merged commit 59ae0df into main Jul 16, 2023
11 checks passed
@ianmkenney ianmkenney deleted the mdadocs branch July 16, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation does not link to itself on the landing page use MDA doc style for docs
2 participants