Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded location_web dependency on js ^0.7.1 to js ^0.6.3 for comp… #942

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

joe-wd
Copy link
Contributor

@joe-wd joe-wd commented Apr 1, 2024

#940
Downgraded location_web dependency on js ^0.7.1 to js ^0.6.3 for compatibility with firebase_core ^2.27.2

✓ changeSettings should call the correct underlying instance
✓ isBackgroundModeEnabled should call the correct underlying instance
✓ enableBackgroundMode should call the correct underlying instance
✓ getLocation should call the correct underlying instance
✓ hasPermission should call the correct underlying instance
✓ requestPermission should call the correct underlying instance
✓ serviceEnabled should call the correct underlying instance
✓ requestService should call the correct underlying instance
✓ changeNotificationOptions should call the correct underlying instance
✓ onLocationChanged should receive values

@bartekpacia
Copy link
Collaborator

Thank you. Please also update version in packages/location/pubspec.yaml and the relevant CHANGELOG file

@joe-wd
Copy link
Contributor Author

joe-wd commented Apr 1, 2024

@bartekpacia Sorry about that. Let me know if I didn't do it correctly. Thanks.

Updated:

  • location_web 5.0.0 --> 5.0.1
  • location_web/CHANGELOG.MD updated
  • location 6.0.0 --> 6.0.1
  • location CHANGELOG.MD updated

@bartekpacia
Copy link
Collaborator

Sorry for not being explicit enough – you only need to update packages/location/pubspec.yaml and packages/location/CHANGELOG.md.

@joe-wd
Copy link
Contributor Author

joe-wd commented Apr 1, 2024

Sorry for not being explicit enough – you only need to update packages/location/pubspec.yaml and packages/location/CHANGELOG.md.

Oops, ok fixed.

@bartekpacia bartekpacia merged commit fe98e65 into Lyokone:master Apr 1, 2024
@bartekpacia
Copy link
Collaborator

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants