Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken symbolic link in "php-parse" #3

Open
gugglegum opened this issue May 3, 2024 · 0 comments
Open

Broken symbolic link in "php-parse" #3

gugglegum opened this issue May 3, 2024 · 0 comments

Comments

@gugglegum
Copy link

gugglegum commented May 3, 2024

The repository contains the php-parse file, which is a symbolic link to the vendor/nikic/php-parser/bin/php-parse file. It makes sense during development when the repository is the root repository and all required dependencies are installed in the vendor folder. However, when using this package normally, it causes an invalid symbolic link to exist. And this leads to problems. For example, in Windows, when you want to copy the whole project directory using xcopy /E /I repo temp:

...
repo\php\vendor\luracast\config\.gitignore
repo\php\vendor\luracast/config.travis.yml.
repo\php\vendor\luracast/config/composer.json.
repo\php\vendor\luracast/config/composer.lock.
repo\php\vendor\luracast/config/LICENSE.txt.
repo/php/vendor/luracast/config/php-parse.
File creation error - The filename, directory name, or volume label syntax is incorrect.

... and all other files cannot be copied because of this error. Problems also occur when archiving the project in ZIP, RAR, etc.

I would like you to remove this file from the repository and create a new stable tag (e.g. 2.0.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant