Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onEnterFullscreen and onExitFullscreen being executed on first render #91

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

heliocosta-dev
Copy link
Contributor

Hello! Not sure if this is the most elegant way but should fix #76 for now.

@LunatiqueCoder
Copy link
Owner

All right, I have one more idea that I need to try, but if it fails, definitely this can be merged.

@LunatiqueCoder LunatiqueCoder enabled auto-merge (squash) May 30, 2024 15:18
@LunatiqueCoder LunatiqueCoder merged commit b50400b into LunatiqueCoder:master May 30, 2024
4 checks passed
@waheedakhtar694
Copy link

I am still having this issue with 2.2.4 version and v6 of video player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onEnterFullscreen and onExitFullscreen both are also being executed on first render of video component.
3 participants