Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework CLI introspections #292

Merged
merged 5 commits into from
Apr 28, 2024
Merged

feat: Rework CLI introspections #292

merged 5 commits into from
Apr 28, 2024

Conversation

LukeMathWalker
Copy link
Owner

--debug was a very overloaded CLI flag: it rendered the full diagnostic error chain, exported perf profiling info and enabled internal logging.
In most cases, that's undesirable:

  • Users will often reach for the full diagnostic error chain
  • Maintainers, instead, will look for perf profiles and internal logging

To better accommodate these usage patterns, --debug will now be limited to diagnostic error chains.
We introduce --perf-profile to emit trace files, --log for internal logging and an explicit --log-filter to configure what gets logged.

@LukeMathWalker
Copy link
Owner Author

/ok-to-test sha=492bc26

@LukeMathWalker LukeMathWalker merged commit 54c9b29 into main Apr 28, 2024
22 checks passed
@LukeMathWalker LukeMathWalker deleted the rework-debug branch April 28, 2024 16:39
@pavex-releaser pavex-releaser bot mentioned this pull request Apr 28, 2024
LukeMathWalker pushed a commit that referenced this pull request Apr 28, 2024
## 🤖 New release
* `pavex`: 0.1.37 -> 0.1.38
* `pavex_bp_schema`: 0.1.37 -> 0.1.38
* `pavex_reflection`: 0.1.37 -> 0.1.38
* `pavex_macros`: 0.1.37 -> 0.1.38
* `persist_if_changed`: 0.1.37 -> 0.1.38
* `pavex_tracing`: 0.1.37 -> 0.1.38
* `pavex_cli`: 0.1.37 -> 0.1.38
* `pavex_miette`: 0.1.37 -> 0.1.38
* `pavexc_cli_client`: 0.1.37 -> 0.1.38
* `pavexc`: 0.1.37 -> 0.1.38
* `pavex_cli_client`: 0.1.37 -> 0.1.38
* `pavexc_cli`: 0.1.37 -> 0.1.38
* `generate_from_path`: 0.1.37 -> 0.1.38

<details><summary><i><b>Changelog</b></i></summary><p>

## `pavex`
<blockquote>

##
[0.1.38](0.1.37...0.1.38)
- 2024-04-28

### Added
- Rework CLI introspections
([#292](#292))

### Fixed
- anyhow::Result<Self> can be returned from constructors and other
fallible components
([#293](#293))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: pavex-releaser[bot] <167640712+pavex-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant