Middlewares: execution order + docs #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While documenting the execution order of middlewares, I realised that the existing implementation resulted in some unintuitive behaviour (i.e. a middleware would apply to all routes in the same
Blueprint
, even if the middleware was registered after a route).This PR changes the behaviour to align with the user's intuition.
Internals
Refactorings lead to other refactorings: I had to change the internal representation of a
Blueprint
to fix the issue with middlewares. I took the opportunity to remove theinternals
module frompavex
entirely. It is now in a separate crate,pavex_bp_schema
, which is not exposed throughpavex
's public API. It is an (implicit) dependency ofBlueprint::persist
andBlueprint::load
.