Add a Form extractor #140
Closed
Add a Form extractor #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's definitely in scope! One thing I noticed it's missing: I'd like the same extractor to handle forms submitted using |
|
Had a second look: it's all 👍🏻 |
|
@LukeMathWalker You mean fall back to query parameters if the body is not set? |
|
No, I mean looking directly at the query parameters if the method is |
|
Closing this since we merged #255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Added an extractor for application/x-www-form-urlencoded requests. This feels common enough that it might warrant inclusion in the framework, but I'll be happy to move it into a third-party package instead.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.