Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: we need nightly #113

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix CI: we need nightly #113

merged 1 commit into from
Dec 10, 2023

Conversation

LukeMathWalker
Copy link
Owner

No description provided.

@LukeMathWalker LukeMathWalker marked this pull request as ready for review December 10, 2023 14:11
@LukeMathWalker LukeMathWalker merged commit 2680be5 into main Dec 10, 2023
3 checks passed
@LukeMathWalker LukeMathWalker deleted the fix-ci branch December 10, 2023 14:42
LukeMathWalker added a commit that referenced this pull request Dec 10, 2023
I've added a `--verify` mode to `tutorial_generator`: expected error
outputs are now committed to `.git` and we verify, in CI, that the
auto-generated ones match what we expect.

This ensures that we never see again a regression like the one we fixed
in #113: the step was failing as expected but with a completely
different error from the one we wanted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant