Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: we should be able to use the type null with IContent #80

Closed
cjxe opened this issue Aug 18, 2023 · 6 comments
Closed

fix: we should be able to use the type null with IContent #80

cjxe opened this issue Aug 18, 2023 · 6 comments

Comments

@cjxe
Copy link
Contributor

cjxe commented Aug 18, 2023

I made a PR for it
@LuisEnMarroquin
Copy link
Owner

thanks, merged 🙌

@LuisEnMarroquin
Copy link
Owner

@cjxe I was going to release a new version of this package but I noticed this type error: https://github.com/LuisEnMarroquin/json-as-xlsx/actions/runs/5904533569/job/16016815345?pr=81

image

@cjxe
Copy link
Contributor Author

cjxe commented Aug 20, 2023

I made another PR where I:

  • fixed this error
  • explained the steps to recover the repo

@cjxe
Copy link
Contributor Author

cjxe commented Aug 25, 2023

fixed!

@cjxe cjxe closed this as completed Aug 25, 2023
@LuisEnMarroquin
Copy link
Owner

@cjxe Thank you 🙌

@cjxe
Copy link
Contributor Author

cjxe commented Aug 25, 2023

Thank you too Luis! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LuisEnMarroquin @cjxe