Fixing pkg-config file

[brad0]

PCSC/meson.build

Line 282 in 78c0832

libraries_private : '-pthread',

With libpcsclite not being linked to libpthread this line should be removed from the pkg-config file too.

Also..

With pcsc-tools you mentioned..

Only libpcsclite_real is linked with the threads library.

But with the Meson build that is not true. Neither library is.

[LudovicRousseau]

I think you are right about libraries_private.

pcsclite_real has a dependency on threads. https://github.com/LudovicRousseau/PCSC/blob/master/meson.build#L170
From the meson logs I get:

[9/19] cc  -o libpcsclite_real.so.1 libpcsclite_real.so.1.p/src_debug.c.o libpcsclite_real.so.1.p/src_winscard_clnt.c.o libpcsclite_real.so.1.p/src_simclist.c.o libpcsclite_real.so.1.p/src_sys_unix.c.o libpcsclite_real.so.1.p/src_utils.c.o libpcsclite_real.so.1.p/src_winscard_msg.c.o -Wl,--as-needed -Wl,--allow-shlib-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libpcsclite_real.so.1 -Wl,--end-group -pthread

So -pthread is used at link stage but that is not a real library, i.e. not something used with -l.

Is it a problem?
I just retried on OpenBSD 7.5 and compilation and link of testpcsc works fine.

[LudovicRousseau]

I am not so sure about the removal of libraries_private.

I added PTHREAD_LIBS in Libs: in 45f45f9
and then moved it in Libs.private: in 26e48e3

But I have not documented WHY I made these changes, and I do not remember (it was in 2004 and 2008).

I do plan to keep it like this. Unless you can demonstrate a problem with that.

[LudovicRousseau]

No feedback since 2 months.
Closing