Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse lookup of class names and auto conversion #18

Draft
wants to merge 23 commits into
base: dev
Choose a base branch
from

Conversation

Davilarek
Copy link
Member

Adds auto conversion of working theme files to our format.

Adds auto conversion of working theme files to our format
@zrodevkaan zrodevkaan marked this pull request as ready for review April 14, 2024 22:35
@zrodevkaan
Copy link
Member

Is this completed?
@Davilarek

@Davilarek
Copy link
Member Author

No, stage 1 needs to return less props, will do later. Currently working on something else.

@zrodevkaan
Copy link
Member

Alright, lmk when the narrowing down the props is completed.

@zrodevkaan zrodevkaan marked this pull request as draft April 14, 2024 22:39
@zrodevkaan
Copy link
Member

Status on this ?

@Davilarek
Copy link
Member Author

I need more complex theme files to test

@DaBluLite
Copy link

@zrodevkaan
Copy link
Member

I'm guessing this was converted?

@DaBluLite
Copy link

No, I mean, don't you want some kind of theme to try reverse lookup on?

@zrodevkaan
Copy link
Member

zrodevkaan commented Apr 29, 2024

Ooh I see, dav will be happy to use that. Thanks DaBluLite

I never saw the message he sent so I just guessed.

@Davilarek
Copy link
Member Author

DaBluLite/Cyan@master/import2.css Try this

Thanks, after quick look at the output file I noticed some conversion errors. I will look into this

@Davilarek
Copy link
Member Author

@zrodevkaan please review this. It's almost ready to merge, I just need more feedback
@DaBluLite I would be thankful if you could test this PR on some theme files and then convert them back to regular theme files to see if something is wrong

@zrodevkaan
Copy link
Member

code looks fine

@Davilarek
Copy link
Member Author

I would like to merge this but no one is interested in testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants