Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-751: Upgrade to Orchard Core 1.8 #234

Merged
merged 44 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #234

merged 44 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024

Copy link
Contributor

coderabbitai bot commented Jan 18, 2024

Walkthrough

The changes involve updating various Lombiq Helpful Libraries projects to target .NET 8.0, optimizing performance, and enhancing asynchronous operations. Notably, updates include framework targeting, package version bumps, constructor parameter adjustments, and method refactoring to utilize asynchronous patterns. These improvements align with modern development practices and dependencies, ensuring compatibility and leveraging new features offered by the updated framework and Orchard Core's latest versions.

Changes

File Path Change Summary
Lombiq.HelpfulLibraries./.csproj Updated target framework to net8.0 and bumped package versions.
Lombiq.HelpfulLibraries.AspNetCore/* Added OrchardCore.Abstractions reference, refactored JsonModelBinder, and optimized ActionResultHelpers.
Lombiq.HelpfulLibraries.Cli/* Modified CliProgram and CliWrapHelper for enhanced command handling.
Lombiq.HelpfulLibraries.Common/* Removed and replaced methods, updated extensions for null inputs, and framework target update.
Lombiq.HelpfulLibraries.LinqToDb/* Removed unnecessary attributes, updated target framework, and refactored LinqToDbConnection.
Lombiq.HelpfulLibraries.OrchardCore/* Various asynchronous method updates, constructor modifications, and refactoring for better dependency injection.
Lombiq.HelpfulLibraries.RestEase/*.csproj Target framework update to net8.0.
Lombiq.HelpfulLibraries.Samples/* Framework target update and package version increment.
Lombiq.HelpfulLibraries.Tests/* Updated to net8.0, asynchronous operations enhancements, and constructor parameter adjustments.

Related issues

  • Upgrade to Orchard Core 1.8 (OSOE-751): The updates to target .NET 8.0, optimization of asynchronous operations, and the addition of OrchardCore.Abstractions package reference directly contribute to preparing the Lombiq Helpful Libraries for compatibility with Orchard Core 1.8. This aligns with the objectives of making the libraries compatible with the latest Orchard Core release and leveraging new asynchronous patterns and setup configurations mentioned in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

…Lombiq.HelpfulLibraries.LinqToDb/LinqToDbConnection.csRevert "Addressing warnings."This reverts commit f2ed7c3.# Conflicts:#	Lombiq.HelpfulLibraries.AspNetCore/Mvc/JsonModelBinder.cs#	Lombiq.HelpfulLibraries.OrchardCore/Contents/TaxonomyHelper.cs#	Lombiq.HelpfulLibraries.OrchardCore/DependencyInjection/InlineStartup.cs#	Lombiq.HelpfulLibraries.OrchardCore/Fields/NoneShapeTableProvider.cs#	Lombiq.HelpfulLibraries.OrchardCore/Liquid/LiquidContentDisplayService.cs#	Lombiq.HelpfulLibraries.OrchardCore/Shapes/PerTenantShapeTableManager.cs#	Lombiq.HelpfulLibraries.OrchardCore/Validation/EmailAndPasswordValidator.cs#	Lombiq.HelpfulLibraries.OrchardCore/Workflow/DocumentedEventActivityDisplayDriverBase.cs

Revert "Addressing warnings."

This reverts commit 44b2009.
# Conflicts:
#	Lombiq.HelpfulLibraries.OrchardCore/Mvc/TypedRoute.cs
#	Lombiq.HelpfulLibraries.Tests/UnitTests/Models/TypedRouteTests.cs
@Psichorex Psichorex merged commit 663a91d into dev Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants