Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-682: Upgrading Lombiq.HelpfulLibraries to OrchardCore 1.7 #216

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Sep 6, 2023

@Piedone Piedone changed the title OSOE-682: Uprading Lombiq.HelpfulLibraries to OrchardCore 1.7 OSOE-682: Upgrading Lombiq.HelpfulLibraries to OrchardCore 1.7 Sep 7, 2023
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these:

    /// <summary>
    /// Gets the given content item's display URL.
    /// </summary>
    [Obsolete($"Use {nameof(GetItemDisplayUrl)} instead as this method does not need to be async.")]
    public static Task<string> GetItemDisplayUrlAsync(this IOrchardHelper orchardHelper, ContentItem contentItem) =>
        Task.FromResult(orchardHelper.GetItemDisplayUrl(contentItem));

    /// <summary>
    /// Gets the given content item's display URL.
    /// </summary>
    [SuppressMessage("Design", "CA1055:URI-like return values should not be strings", Justification = "It only returns relative URL.")]
    public static string GetItemDisplayUrl(this IOrchardHelper orchardHelper, ContentItem contentItem) =>
        orchardHelper.GetItemDisplayUrl(contentItem?.ContentItemId);

@Psichorex Psichorex merged commit 3625d4c into dev Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants