Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): export initDiscord function #17

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Exporting the initDiscord function allows us to call it from a vue app.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.62%. Comparing base (0aad866) to head (6d6a64e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/js/discord.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   55.31%   65.62%   +10.30%     
===========================================
  Files           8        8               
  Lines          94       96        +2     
  Branches       15       15               
===========================================
+ Hits           52       63       +11     
+ Misses         42       33        -9     
Files with missing lines Coverage Δ
src/js/discord.js 84.61% <75.00%> (+84.61%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix/discord/export-initDiscord-function branch from 9041367 to 6d6a64e Compare September 1, 2024 16:52
@ReenigneArcher ReenigneArcher merged commit 0c3286e into master Sep 1, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/discord/export-initDiscord-function branch September 1, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant