Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure source code #584

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

Description

Changes mostly based on LizardByte/Themerr-plex#497

In the future maybe we can combine these into one project...

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the refactor/restructure-source-code branch 2 times, most recently from eec9586 to 121ebe7 Compare August 9, 2024 23:17
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 62.40000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (01d4d90) to head (5457d27).

Files Patch % Lines
src/retroarcher.py 0.00% 23 Missing ⚠️
src/common/webapp.py 60.97% 16 Missing ⚠️
src/common/config.py 73.07% 7 Missing ⚠️
src/common/__init__.py 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (01d4d90) and HEAD (5457d27). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (01d4d90) HEAD (5457d27)
Windows-x64 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   74.03%   66.19%   -7.84%     
==========================================
  Files          10       11       +1     
  Lines         905     1056     +151     
==========================================
+ Hits          670      699      +29     
- Misses        235      357     +122     
Flag Coverage Δ
Linux-x64 62.40% <60.80%> (-7.21%) ⬇️
Windows-x64 ?
Windows-x86 65.53% <62.40%> (-7.73%) ⬇️
macOS-x64 65.71% <62.40%> (-7.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/definitions.py 83.33% <100.00%> (ø)
src/common/hardware.py 78.26% <100.00%> (ø)
src/common/helpers.py 70.58% <ø> (ø)
src/common/locales.py 83.72% <100.00%> (ø)
src/common/logger.py 61.03% <100.00%> (ø)
src/common/threads.py 100.00% <ø> (ø)
src/common/tray_icon.py 83.03% <100.00%> (ø)
src/common/__init__.py 63.63% <80.00%> (ø)
src/common/config.py 80.73% <73.07%> (ø)
src/common/webapp.py 70.14% <60.97%> (ø)
... and 1 more

@ReenigneArcher ReenigneArcher force-pushed the refactor/restructure-source-code branch 18 times, most recently from bba5e71 to 82c8c64 Compare August 15, 2024 03:16
Copy link

sonarcloud bot commented Sep 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31 New issues
4 Security Hotspots
31 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant