Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream the WebAssembly HTTP Client implementation as gloo-http #9

Open
CryZe opened this issue Dec 12, 2019 · 1 comment
Open

Upstream the WebAssembly HTTP Client implementation as gloo-http #9

CryZe opened this issue Dec 12, 2019 · 1 comment
Labels
enhancement New feature or request.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Dec 12, 2019

For the speedrun.com API we use the exact same code. Instead of copy pasting it, we should make it available via some crate that anyone can use. One possibility is to usptream it into the http-client crate, which already has a similar, but really buggy implementation. However I consider those maintainers fairly toxic, so I'm not sure if I really want to upstream the code into that repository.

Additionally for the event stream we are introducing an async WebSocket implementation which we likely also want to upstream somewhere. The http-client crate may not be what we want for that as it doesn't have any WebSocket capabilities and we would need to provide one for their native backends. However for the native implementation we use tokio-tungstenite and the http-client maintainers have personal issues with the tokio maintainers. So that will cause even more problems.

I really just want to make a gloo-http crate (gloo is the JS APIs but as idiomatic Rust, so gloo-http would be ideal), but I'm not sure if making such a crate without having talked to the gloo maintainers beforehand is a good idea.

@CryZe CryZe added enhancement New feature or request. needs more discussion There are some outstanding decisions that need to be made. labels Dec 12, 2019
@CryZe
Copy link
Collaborator Author

CryZe commented Dec 18, 2019

It is pretty obvious now that the way to go is to create a PR to gloo to add the code as the gloo-http crate. People seem to be on board with that and crates like reqwest and http-client can then depend on gloo-http for their http implementation.

@CryZe CryZe removed the needs more discussion There are some outstanding decisions that need to be made. label Dec 18, 2019
@CryZe CryZe changed the title Possibly upstream the WebAssembly HTTP Client implementation into some crate Upstream the WebAssembly HTTP Client implementation as gloo-http Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant