auto_splitting feature: Add requests for auto splitter settings management #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds 4 requests to the auto-splitting feature so that the library users are able to manage the auto splitter settings: - GetSettings: Gets all of the user settings that are meant to be shown to the runner - GetSettingsValue(key: String): Gets the SettingValue of a specific setting - SetSettingsValue(key: String, value: SettingValue): Sets the SettingValue of a specific setting - ReloadScript: Helper request that will reload the current script while keeping the same SettingsStore This adds 3 new possible errors to tell the user what could have went wrong while executing the requests. It also re export some of the useful types for settings related things. Lastly, there's a new accessor in the runtime to get the SettingsStore as mutable and UserSetting / UserSettingKind are now clonable so that we can pass them along with the requests.
|
Ah yes, the CI is very green. Let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds 4 requests to the auto-splitting feature so that the library users are able to manage the auto splitter settings:
These new requests are part of my ongoing work towards having the settings editable in the obs-livesplit-one UI, I have tested them to work as expected.
I don't know why the Windows i686 gnu build fails but it doesn't seem like it's related to this pull request?