Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for UE 5.4 #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Jujstme
Copy link
Contributor

@Jujstme Jujstme commented Apr 30, 2024

No description provided.

const GWORLD: &[(Signature<22>, u8)] = &[
(
Signature::new(
"80 7C 24 ?? 00 ?? ?? 48 8B 3D ?? ?? ?? ?? 48 ?? ?? ?? ?? ?? ?? ??",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing masks seem pointless to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are needed for having a Signature<22>, which in turn is needed because I'm looping the sigscan over an array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you can't just make it a Signature<15>...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Signature<22> and Sifgnature<15> are different types, so you can't make an array of them,
And the second signature needs to be 22.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like incredibly flawed design.

Copy link
Collaborator

@CryZe CryZe Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do something like this: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=5215e39801e621c2c1fb432363276152

Instead of storing signatures in the array, you store function pointers.

Jujstme added a commit to Jujstme/asr that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants