-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some browsers optional? #7
Comments
Unfortunately, this is quite hard with npm. One way would be to split out each "adapter" into a separate package, and then you'd have to install e.g. To be honest though, I would be quite happy with just dropping Opera. It seems like there is some error with it at the moment, and I don't know if anyone actually uses it. My experience with Opera is that they aren't interested in maintaining their extension gallery at all, and they are extremely slow at responding when posting extensions... |
Haha, this + #8 really makes you think about how fragile npm modules are. Yeah the module splitting option would be great! It would probably also make it easier to maintain the code for each browser's deploy. Yeah, I guess if puppeteer is the only way to make changes to extensions on your store, you probably either don't care about extensions or don't have enough people regularly updating extensions on your store to make you care 😄 Could an optional dependency work for this? https://docs.npmjs.com/files/package.json#optionaldependencies |
To prevent, downloading bundled Chromium during installation step you can set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable to 1 puppeteer environment-variables |
I don't know if this is possible, but it would be cool if I could not install the dependencies for opera, which includes the very heavy puppeteer, if I'm not going to be deploying there.
The text was updated successfully, but these errors were encountered: