Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some browsers optional? #7

Open
spookyuser opened this issue Nov 10, 2018 · 3 comments
Open

Make some browsers optional? #7

spookyuser opened this issue Nov 10, 2018 · 3 comments

Comments

@spookyuser
Copy link

I don't know if this is possible, but it would be cool if I could not install the dependencies for opera, which includes the very heavy puppeteer, if I'm not going to be deploying there.

spookyuser pushed a commit to spookyuser/laconic_hover that referenced this issue Nov 10, 2018
@LinusU
Copy link
Owner

LinusU commented Nov 12, 2018

Unfortunately, this is quite hard with npm. One way would be to split out each "adapter" into a separate package, and then you'd have to install e.g. @wext/shipit-chrome and @wext/shipit-firefox to target those platforms. That could potentially be nice 🤔

To be honest though, I would be quite happy with just dropping Opera. It seems like there is some error with it at the moment, and I don't know if anyone actually uses it.

My experience with Opera is that they aren't interested in maintaining their extension gallery at all, and they are extremely slow at responding when posting extensions...

@spookyuser
Copy link
Author

Haha, this + #8 really makes you think about how fragile npm modules are. Yeah the module splitting option would be great! It would probably also make it easier to maintain the code for each browser's deploy.

Yeah, I guess if puppeteer is the only way to make changes to extensions on your store, you probably either don't care about extensions or don't have enough people regularly updating extensions on your store to make you care 😄

Could an optional dependency work for this? https://docs.npmjs.com/files/package.json#optionaldependencies

@andriyor
Copy link

To prevent, downloading bundled Chromium during installation step you can set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable to 1 puppeteer environment-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants