Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does it put artifacts? #12

Open
ianwremmel opened this issue Apr 2, 2019 · 5 comments
Open

Where does it put artifacts? #12

ianwremmel opened this issue Apr 2, 2019 · 5 comments

Comments

@ianwremmel
Copy link

I'm using this in conjunction with semantic-release and I'd like to upload the firefox xpi/chrome zip file to the corresponding GitHub release at the end of the build, but it's not clear to me where those files end up.

@LinusU
Copy link
Owner

LinusU commented Apr 2, 2019

It's using the --source-dir option with web-ext (firefox) and --source option with webstore (chrome) and thus I think that there is never any artifacts outputted...

How do you usually get your artifacts? Are you using web-ext and webstore today?

@ianwremmel
Copy link
Author

I had been using web-ext to generate zip and xpi files, then going through the UIs to publish them.

I actually ended up bypassing this script and calling web-ext sign directly. Mozilla's docs really make it unclear that sign can submit packages. Turns out, sign both submits a package and drops its xpi in ./web-ext-artifacts by default.

I'm guessing I'm going to end up swapping this out for calling something like web-ext build && webstore to detail with Chrome. I'd previously been unaware of webstore.

@ianwremmel
Copy link
Author

ianwremmel commented Apr 2, 2019

I actually ended up bypassing this script and calling web-ext sign directly.

I did this for two reasons:

  1. so that I could pass --id to web-ext rather than putting the id in the manifest
  2. for publicly listed extensions, the success string that your firefox script looks for is never found, so it was exiting with an error.

@LinusU
Copy link
Owner

LinusU commented Apr 2, 2019

  1. so that I could pass --id to web-ext rather than putting the id in the manifest

Would be happy to add WEXT_SHIPIT_FIREFOX_EXTENSION_ID env variable for passing --id

  1. for publicly listed extensions, the success string that your firefox script looks for is never found, so it was exiting with an error.

🤔 I've tried this with publicly listed extensions, would you mind providing the string it's outputting for you?

@ianwremmel
Copy link
Author

Mobile at the moment, so here’s a link to the script I ended up using: https://github.com/ianwremmel/browser-ruler/blob/master/scripts/firefox.sh

Rather than adding explicit env vars, what about searching env for everything that’s appropriately name spaced and transforming it into switches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants