-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test in npm-deps.test.ts
#65
Labels
Comments
LinqLover
added a commit
that referenced
this issue
Jun 22, 2021
With this change, the rate of promise failures is already lowered from ca. 1/2 to 1/50, but from time to time, the bug still appears. Sigh ...
LinqLover
changed the title
Flaky test in
Flaky test in Jun 22, 2021
npm-deps.test.ts
?npm-deps.test.ts
With 472d90f the likeliness of a flaky failing job has already been reduced significantly. However, in rare cases, the issue still exists, and I located the origin of these failures in 5f3a609/#38. For the moment, I do not see anything else that could be done, but the issue is being tracked further here and discussed in jestjs/jest#11601 and TomerAberbach/parse-imports#3. |
LinqLover
added a commit
that referenced
this issue
Oct 12, 2021
After restructuring the core package, dynamic imports did not work any longer because apparently, they must not be called from submodules. Relates #65 and microsoft/TypeScript#43329, again.
LinqLover
added a commit
that referenced
this issue
Oct 12, 2021
Among others, this adds crash tests for the extension and makes it compatible with Windows. * Document CLI * Document, restructure, and refactor core * Rename `npm run install-all` (previously `update-lockfiles`) * Fix type error * Document & clean-up VSCE * Update UPSTREAM.md * Update README.mds * Enhance documentation * Revise todo comments * Document initial configuration of the extension * Add debug messages * Fix file path handling for Windows Now I really \hate\ backslashes ... * TypeReferenceSearcher: Fix exclusion of irrelevant node_modules folders The target package or the analyzed dependency may indeed be located in a node_modules folder. * Add smoke test for extension * VSCE: Decline stars and forks correctly * VSCE: Prevent errors when opening a dependency directory * Fix VSCE test path * Fix another path * Fix just another test path * cli: fix oclif hook * Fix TypeScript configuration paths for vsce once and for all. * Fix import errors from core package once again After restructuring the core package, dynamic imports did not work any longer because apparently, they must not be called from submodules. Relates #65 and microsoft/TypeScript#43329, again. * Please linter * Fix module resolution for Windows * Specify missing dependency on path-exists * Fix import of path-exists * Add installation instructions to global README.md * Fix npm tests (add missing loadExternalModules()) * Engross package path-exists to eliminate dependency on node:fs which does not work in jest tests 🤯 * Fix npm tests by limitting concurrency Just another workaround for nasty jest ... * Remove dangling debug artifacts * Refine README.mds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relevant job logs:
The text was updated successfully, but these errors were encountered: