From 89e284b76497bf50a07fcb33ddcd6c345259efeb Mon Sep 17 00:00:00 2001 From: Katie Worton Date: Mon, 13 Nov 2023 14:47:45 +0000 Subject: [PATCH] tests/test_shortcuts: Fix check for success on submit_results return Since submit_results now returns two values (success and testrun ID), the test_basic for submit_results needs to be updated to reflect this, otherwise the assertion will always return True. Signed-off-by: Katie Worton --- tests/test_shortcuts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_shortcuts.py b/tests/test_shortcuts.py index 6e0790c..eb493e7 100644 --- a/tests/test_shortcuts.py +++ b/tests/test_shortcuts.py @@ -46,7 +46,7 @@ def test_basic(self): metadata = {"job_id": "12345", "a-metadata-field": "value"} tests = {"testa": "pass", "testb": {"result": "pass", "log": "the log"}} metrics = {"metrica": 42} - success = submit_results( + success, testrun_id = submit_results( group_project_slug="my_group/my_project", build_version="my_build", env_slug="my_env",