WIP: jiralogin: Add support for token_auth authentication #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-hosted Jira instances can't use the API token authentication, but must instead rely on the Personal Access Token authentication scheme. This patch introduces support for this authentication method as the third mode of authenticating. [1] https://jira.readthedocs.io/examples.html#token-auth Signed-off-by: Robert Foss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-hosted Jira instances can't use the API token authentication, but must instead rely on the Personal Access Token authentication scheme[1].
This patch introduces support for this authentication method as the third mode of authenticating.
[1] https://jira.readthedocs.io/examples.html#token-auth
This PR is missing a convenient way to specify that this login method is the desired one. Something along the lines of
jipdate --init --auth auth_token/token/password --token abcdefghjkl --server jira.company.comPersonally find the python-jira nomenclature around token/auth_token to be quite confusing so maybe referring to the different tokens as
cloud_tokenandpersonal_tokenwould make more sense.