-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite file list #3746
feat: rewrite file list #3746
Conversation
3a5376d
to
323226d
Compare
323226d
to
98350fa
Compare
02cf17b
to
b2a69f4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
523ce99
to
5da838d
Compare
81b94ed
to
17adce7
Compare
3f6e60b
to
842be69
Compare
/backport to stable30 |
/backport to stable29 |
To thinkto-do
For now, the the delete feature only delete the signature request, only at LibreSing tables.. I thought in 2 possible ways to solve this but will be necessary to think what's the best:
PS: I prefer the option 1 more from the previous subject. Going more deep into other points:
At LibreSign menu we have the action "Request". With this PR we also have the request inside action "Files" with the same options (upload new file, request from URL and choose from app Files). Maybe we can remove the action "Request" from main LibreSign menu because sounds as redundant. My opinion: The "Request" at LibreSign menu sounds more clear and easy to identify how to upload a new file, but... we can implement a first run wizard explaining to an admin account about how to request to sign a file. Would be best to implement a "first run wizard" into a new PR do don't make too complex this PR. |
To who see this PR: A point that will make me and everyone involved in the development of LibreSign very happy is if we receive more recurring funding from LibreSign's GitHub Sponsor. This will greatly help to keep the project developing. If you have any other ideas on how to help the project continue to improve, we would be happy to hear from you: [email protected] |
I agree that option 1 would be easier UX to most users, it is also very similar to how whatsapp handles "delete media" in chats p.s. |
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Victor Bianchi <[email protected]>
Signed-off-by: Victor Bianchi <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Victor Bianchi <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
This asort change the order of parameters: https://github.com/nextcloud/server/blob/bb1e2f9d9d51e83da6ee0da9ce5fb2e415542119/lib/private/Route/CachingRouter.php#L51 Signed-off-by: Vitor Mattos <[email protected]>
We haven't this status implemented yet Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
3d571bf
to
454b8d3
Compare
Signed-off-by: Vitor Mattos <[email protected]>
Implement