Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix: make compatible with FPDF #2672

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[stable28] fix: make compatible with FPDF #2672

merged 2 commits into from
Apr 5, 2024

Commits on Apr 5, 2024

  1. fix: make compatible with FPDF 

    I identified an edge case parsing a PDF generated with FPDF. The MediaBox don't exists at page scope and was necessary to get from document scope.

Signed-off-by: Vitor Mattos <[email protected]>
    @vitormattos @backportbot-libresign
    vitormattos authored and backportbot-libresign[bot] committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a60ba4a View commit details
    Browse the repository at this point in the history

  2. fix: prevent psalm error 

    ```
ERROR: InvalidPassByReference - lib/Service/PdfParserService.php:76:22 - Parameter 1 of reset expects a variable (see https://psalm.dev/102)
				$details = reset($pdf->getObjectsByType('Pages'))->getHeader()->getDetails();
```

Signed-off-by: Vitor Mattos <[email protected]>
    @vitormattos @backportbot-libresign
    vitormattos authored and backportbot-libresign[bot] committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    eda1082 View commit details
    Browse the repository at this point in the history